Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix(Grid): Fix activeStyle type (#2996) #3015

Merged
merged 1 commit into from
Dec 28, 2018
Merged

Fix(Grid): Fix activeStyle type (#2996) #3015

merged 1 commit into from
Dec 28, 2018

Conversation

zack24q
Copy link
Contributor

@zack24q zack24q commented Dec 28, 2018 •
edited by paranoidjk
Loading

First of all, thank you for your contribution! :-)

Please makes sure that these checkboxes are checked before submitting your PR, thank you!

  • Make sure that you follow antd's code convention.
  • Run npm run lint and fix those errors before submitting in order to keep consistent code style.
  • Rebase before creating a PR to keep commit history clear.
  • Add some descriptions and refer relative issues for you PR.

Extra checklist:

if isBugFix :

  • Make sure that you add at least one unit test for the bug which you had fixed.

elif isNewFeature :

  • Update API docs for the component.
  • Update/Add demo to demonstrate new feature.
  • Update TypeScript definition for the component.
  • Add unit tests for the feature.

This change is Reviewable

@zack24q zack24q requested a review from ziluo December 28, 2018 02:38
@ghost ghost assigned zack24q Dec 28, 2018
@ghost ghost added the In Progress label Dec 28, 2018
@zack24q
Copy link
Contributor Author

zack24q commented Dec 28, 2018

close #2996

@codecov
Copy link

codecov bot commented Dec 28, 2018 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@dc0d8fc). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##             master   #3015   +/-   ##
========================================
  Coverage          ?   60.1%           
========================================
  Files             ?      92           
  Lines             ?    2246           
  Branches          ?     643           
========================================
  Hits              ?    1350           
  Misses            ?     887           
  Partials          ?       9
Flag Coverage Δ
#web 60.1% <ø> (?)
Impacted Files Coverage Δ
components/grid/index.tsx 92% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc0d8fc...41cf2c7. Read the comment docs.

@ziluo ziluo merged commit a991981 into master Dec 28, 2018
@ziluo ziluo deleted the fix-grid-active-style branch December 28, 2018 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ziluo ziluo Awaiting requested review from ziluo

Assignees

@zack24q zack24q

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zack24q @ziluo